Re: SQL/JSON: functions

Andrew Dunstan <andrew@dunslane.net>

From: Andrew Dunstan <andrew@dunslane.net>

To: Justin Pryzby <pryzby@telsasoft.com>

Cc: Himanshu Upadhyaya <upadhyaya.himanshu@gmail.com>, Nikita Glukhov <n.gluhov@postgrespro.ru>, pgsql-hackers@postgresql.org, Dmitry Dolgov <9erthalion6@gmail.com>, Oleg Bartunov <obartunov@postgrespro.ru>, Erik Rijkers <er@xs4all.nl>

Date: 2022-03-24T22:51:30Z

Lists: pgsql-hackers

Attachments

0001-Common-SQL-JSON-clauses-v65.patch (text/x-patch) patch v65-0001
0002-SQL-JSON-constructors-v65.patch (text/x-patch) patch v65-0002
0003-IS-JSON-predicate-v65.patch (text/x-patch) patch v65-0003
0004-SQL-JSON-query-functions-v65.patch (text/x-patch) patch v65-0004
0005-SQL-JSON-functions-for-json-type-v65.patch (text/x-patch) patch v65-0005
0006-RETURNING-clause-for-JSON-and-JSON_SCALAR-v65.patch (text/x-patch) patch v65-0006

On 3/23/22 16:56, Justin Pryzby wrote:
> On Wed, Mar 23, 2022 at 03:49:17PM -0400, Andrew Dunstan wrote:
>> On 3/23/22 08:24, Justin Pryzby wrote:
>>> At least 0002-SQL-JSON-constructors-v64.patch has an issue with nodes,
>>> per COPY_PARSE_PLAN_TREES.
>>>
>>> +ERROR:  unrecognized node type: 157
>> I just tried to reproduce this and was unable to.  Ubuntu 20.04, gcc 9.4.0.
>>
>> the build was done with CPPFLAGS=-DCOPY_PARSE_PLAN_TREES. To be on the
>> safe side I took ccache out of the equation.
>>
>> Can you give me any more details?
> Sorry, the issue was actually with 
>
> #define RAW_EXPRESSION_COVERAGE_TEST
>
> make check is enough to see it:
>
> @@ -6,181 +6,78 @@
>  (1 row)
>  
>  SELECT JSON_OBJECT(RETURNING json);
> - json_object 
> --------------
> - {}
> -(1 row)
> -
> +ERROR:  unrecognized node type: 157
> [...]


Here's a new patch set that fixes this and several similar issues.
Thanks to my colleague  Masahiko Sawada for providing fixes for some of
these at very short notice.


I wonder if we should add these compile flags to the cfbot's setup?


cheers


andrew


--
Andrew Dunstan
EDB: https://www.enterprisedb.com

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

JSON_TABLE: Add support for NESTED paths and columns
- bb766cde63b4 17.0 landed
Add basic JSON_TABLE() functionality
- de3600452b61 17.0 landed
Add SQL/JSON query functions
- 6185c9737cf4 17.0 landed
Add soft error handling to some expression nodes
- aaaf9449ec6b 17.0 landed
Adjust populate_record_field() to handle errors softly
- 1edb3b491bee 17.0 landed
Refactor code used by jsonpath executor to fetch variables
- faa2b953ba3b 17.0 landed
Add more SQL/JSON constructor functions
- 03734a7fed7d 17.0 landed
SQL/JSON: support the IS JSON predicate
- 6ee30209a6f1 16.0 landed
SQL/JSON: add standard JSON constructor functions
- 7081ac46ace8 16.0 landed
Improve readability of SQL/JSON documentation.
- b46bcf7a4b6f 15.0 landed
Documentation for SQL/JSON features
- a6baa4baddd5 15.0 landed
RETURNING clause for JSON() and JSON_SCALAR()
- 49082c2cc3d8 15.0 landed
SQL JSON functions
- 606948b058dc 15.0 landed
SQL/JSON query functions
- 1a36bc9dba8e 15.0 landed
IS JSON predicate
- 33a377608fc2 15.0 landed
SQL/JSON constructors
- f4fb45d15c59 15.0 landed
Common SQL/JSON clauses
- f79b803dcc98 15.0 landed
- 865fe4d5df56 15.0 landed
Doc: remove obsolete entries in table of BRIN strategy numbers.
- 0ce4cd04da55 14.0 cited
Doc: standardize markup a bit more.
- 47046763c3ed 13.0 cited
Make pg_regress.c unset PGDATABASE during make installcheck.
- 5ee96b3e2221 13.0 cited
Fix handling of GENERATED columns in CREATE TABLE LIKE INCLUDING DEFAULTS.
- b81a9c2fc525 13.0 cited