Re: Cygwin - make check broken
Andrew Dunstan <andrew@dunslane.net>
From: Andrew Dunstan <andrew@dunslane.net>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Marko Kreen <marko@l-t.ee>, pgsql-hackers@postgresql.org, Rocco Altier <RoccoA@Routescape.com>
Date: 2005-08-08T00:44:18Z
Lists: pgsql-hackers
Tom Lane wrote: >Andrew Dunstan <andrew@dunslane.net> writes: > > >>Marko Kreen wrote: >> >> >>>On Sun, Aug 07, 2005 at 12:08:28PM -0400, Tom Lane wrote: >>> >>> >>>>Couple thoughts here --- one, someone upthread suggested >>>>"cyg$(NAME)$(DLSUFFIX" as the proper value for shlib. >>>> >>>> >>>.exe's in different directories than .dll's but all in PATH. >>> >>> > > > >>Especially DLLs in the system directory. Anyway, I see no point *not* to >>observe the platform's convention. >> >> > > > >>I just tested it and make check worked fine. >> >> > >OK, applied with the "cyg" prefix. > >When you get a chance, would you see if the SHLIB_LINK += $(LIBS) >bit is still needed? > > > > I commented it out of the Cygwin stanza and all seemed fine - contrib built and passed installcheck quite happily. cheers andrew