Re: [PATCH] pgcrypto: pgp_encrypt (v2)

Neil Conway <neilc@samurai.com>

From: Neil Conway <neilc@samurai.com>
To: Marko Kreen <marko@l-t.ee>
Cc: Bruce Momjian <pgman@candle.pha.pa.us>, pgsql-patches@postgresql.org
Date: 2005-07-04T06:59:58Z
Lists: pgsql-hackers

Attachments

Marko Kreen wrote:
> Please use following updated patch instead.
> 
> It implements utf8 conversion, fixes couple of bugs and has
> many code and comment cleanups.

The regression tests don't pass on my box. With the default Makefile, 
there are a lot of errors WRT "no strong random source". After editing 
the Makefile to make use the "random" device, I get the attached 
regression.diffs.

While I understand the need to make sure people use a reasonably strong 
crypto source, it would be nice if the regression tests passed out of 
the box.

-Neil