Re: Change GUC hashtable to use simplehash?

Anton A. Melnikov <a.melnikov@postgrespro.ru>

From: "Anton A. Melnikov" <a.melnikov@postgrespro.ru>

To: John Naylor <johncnaylorls@gmail.com>

Cc: Tom Lane <tgl@sss.pgh.pa.us>, Jeff Davis <pgsql@j-davis.com>, Ants Aasma <ants.aasma@cybertec.at>, Heikki Linnakangas <hlinnaka@iki.fi>, Junwang Zhao <zhjwpku@gmail.com>, jian he <jian.universality@gmail.com>, Andres Freund <andres@anarazel.de>, Gurjeet Singh <gurjeet@singh.im>, pgsql-hackers@postgresql.org

Date: 2025-02-13T02:58:07Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Silence warning in older versions of Valgrind
- fde7c0164ea2 17.5 landed
- 0600d276d485 18.0 landed
Revert "Speed up tail processing when hashing aligned C strings, take two"
- 6555fe197914 17.3 landed
- 235328ee4ae4 18.0 landed
Speed up tail processing when hashing aligned C strings, take two
- a365d9e2e8c1 17.0 landed
Teach fasthash_accum to use platform endianness for bytewise loads
- 0c25fee35903 17.0 landed
Add macro to disable address safety instrumentation
- db17594ad73a 17.0 landed
Convert uses of hash_string_pointer to fasthash equivalent
- f956ecd0353b 17.0 landed
Speed up tail processing when hashing aligned C strings
- 07f0f6abfc7f 17.0 landed
Add helper functions for dshash tables with string keys.
- 42a1de3013ea 17.0 cited
Fix warnings in cpluspluscheck
- 257998508672 17.0 landed
Further cosmetic review of hashfn_unstable.h
- b83033c3cff5 17.0 landed
Simplify initialization of incremental hash state
- 9ed3ee5001b6 17.0 landed
Add optimized C string hashing
- 0aba2554409e 17.0 landed
Add inline incremental hash functions for in-memory use
- e97b672c88f6 17.0 landed
Make all Perl warnings fatal
- c5385929593d 17.0 cited

Hi, John!

On 13.02.2025 04:49, John Naylor wrote:
> On Thu, Feb 13, 2025 at 3:42 AM Anton A. Melnikov
> <a.melnikov@postgrespro.ru> wrote:

>> On 29.01.2025 10:02, John Naylor wrote:
>>> This is done -- thanks for the report, and for testing.
>>
>> It's good that this is done! But i still see the problem.
> 
> Hi, my understanding was you previously tested with the revert. Did
> you not actually test, or are you building differently for these
> cases?

My first test [1] was made at b7493e1
while the second [2] at ecb8226a after reverting in the 235328ee.

The build process was the same in both cases.

Both [1] and [2] contain pg_rightmost_one_pos64() call
that lead to a valgrind error.

Also i did this test very far back at e97b672c88 [3]
and found no errors.


With the best regards,

-- 
Anton A. Melnikov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

[1] https://www.postgresql.org/message-id/a3a959f6-14b8-4819-ac04-eaf2aa2e868d%40postgrespro.ru
[2] https://www.postgresql.org/message-id/f3aa2d45-3b28-41c5-9499-a1bc30e0f8ec%40postgrespro.ru
[3] https://www.postgresql.org/message-id/4c739718-27d6-44fe-9113-56a251c13275%40postgrespro.ru