Horton

Re: Rename of triggers for partitioned tables

Arne Roland <a.roland@index.de>

View thread View on postgr.es
From: Arne Roland <A.Roland@index.de>
To: Tom Lane <tgl@sss.pgh.pa.us>, Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: vignesh C <vignesh21@gmail.com>, Zhihong Yu <zyu@yugabyte.com>, Pg Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-07-26T18:11:28Z
Lists: pgsql-hackers 
From: Tom Lane <tgl@sss.pgh.pa.us>
Sent: Monday, July 26, 2021 19:38
To: Alvaro Herrera
Subject: Re: Rename of triggers for partitioned tables

> Yeah, we don't support partial indexes on catalogs, and this example
> doesn't make me feel like we ought to open that can of worms.

I asked why such an index doesn't exists already. I guess that answers it. I definitely don't want to push for supporting that, especially not knowing what it entails.

> But then maybe this function shouldn't assume there's only one match?

 I'd consider a duplication here a serious bug. That is pretty much catalog corruption. Having two children within a single child table sounds like it would break a lot of things.

That being said this function is hardly performance critical. I don't know whether throwing an elog indicating what's going wrong here would be worth it.

Regards
Arne

Commits

  1. Remove newly added useless assertion check

  2. Make ALTER TRIGGER RENAME consistent for partitioned tables

  3. Fix pg_dump for disabled triggers on partitioned tables

  4. Preserve firing-on state when cloning row triggers to partitions

  5. Fix ALTER TABLE .. ENABLE/DISABLE TRIGGER recursion

  6. Record parents of triggers

  7. Allow FOR EACH ROW triggers on partitioned tables