Horton

Re: Declarative partitioning vs. sql_inheritance

Amit Langote <langote_amit_f8@lab.ntt.co.jp>

View thread View on postgr.es
From: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
To: Robert Haas <robertmhaas@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>, Dmitry Ivanov <d.ivanov@postgrespro.ru>, Michael Paquier <michael.paquier@gmail.com>, Andres Freund <andres@anarazel.de>, Erik Rijkers <er@xs4all.nl>, Amit Langote <amitlangote09@gmail.com>, Rajkumar Raghuwanshi <rajkumar.raghuwanshi@enterprisedb.com>, Ashutosh Bapat <ashutosh.bapat@enterprisedb.com>, Pg Hackers <pgsql-hackers@postgresql.org>, pgsql-hackers-owner@postgresql.org
Date: 2016-12-19T05:25:56Z
Lists: pgsql-hackers 
On 2016/12/17 10:40, Robert Haas wrote:
> On Fri, Dec 16, 2016 at 7:39 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
>>> On 12/16/16 11:05 AM, Robert Haas wrote:
>>>> If we were going to do anything about this,
>>>> my vote would be to remove sql_inheritance.
>>
>>> Go for it.
>>
>>> Let's also remove the table* syntax then.
>>
>> Meh --- that might break existing queries, to what purpose?
>>
>> We certainly shouldn't remove query syntax without a deprecation period.
>> I'm less concerned about that for GUCs.
> 
> I agree.  Patch attached, just removing the GUC and a fairly minimal
> amount of the supporting infrastructure.

+1 to removing the sql_inheritance GUC.  The patch looks good to me.

Thanks,
Amit

Commits

  1. Replace enum InhOption with simple boolean.

  2. Remove sql_inheritance GUC.