Re: Windows: openssl & gssapi dislike each other

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>

To: Andrew Dunstan <andrew@dunslane.net>

Cc: Imran Zaheer <imran.zhir@gmail.com>, Dave Page <dpage@pgadmin.org>, PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>

Date: 2024-06-08T22:21:24Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Move GSSAPI includes into its own header
- e92c0632c147 18.0 landed
Tighten test_predtest's input checks, and improve error messages.
- 00ac25a3c365 17.0 cited
Collation documentation fixes.
- 8ba34c698d19 17.0 cited
contrib/sslinfo needs a fix too to make hamerkop happy.
- 568620dfd691 15.0 cited
Second attempt to silence SSL compile failures on hamerkop.
- 1241fcbd7e64 15.0 cited

Andrew Dunstan <andrew@dunslane.net> writes:
> On 2024-06-08 Sa 06:22, Imran Zaheer wrote:
>> Now this can either be solved by just just undefine the macro defined
>> by wincrypt.h as done here [3]
>> Or we should rearrange our headers. Openssl header should be at the
>> bottom (after the gssapi includes).

> Let's be consistent and use the #undef from [3].

+1.  Depending on header order is not great, especially when you have
to make it depend on an order that is directly contradictory to
project conventions [0].

			regards, tom lane

[0] https://wiki.postgresql.org/wiki/Committing_checklist#Policies