Horton

Re: pltcl crash on recent macOS

Peter Eisentraut <peter.eisentraut@enterprisedb.com>

View thread View on postgr.es
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Thomas Munro <thomas.munro@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2022-06-23T07:54:28Z
Lists: pgsql-hackers 
On 20.06.22 12:36, Peter Eisentraut wrote:
> On 14.06.22 05:05, Tom Lane wrote:
>> I'd be okay with just dropping the -lc from pl/tcl/Makefile and seeing
>> what the buildfarm says.  The fact that we needed it in 1998 doesn't
>> mean that we still need it on supported versions of Tcl; nor was it
>> ever anything but a hack for us to be overriding what TCL_LIBS says.
> 
> Ok, I propose to proceed with the attached patch (with a bit more 
> explanation added) for the master branch (for now) and see how it goes.

done

Commits

  1. PL/Tcl: Don't link with -lc explicitly

  2. Build pltcl.so correctly on platforms that want dependent