Horton

Re: pg_resetwal tests, logging, and docs update

Peter Eisentraut <peter@eisentraut.org>

View thread View on postgr.es
From: Peter Eisentraut <peter@eisentraut.org>
To: Aleksander Alekseev <aleksander@timescale.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2023-09-13T18:34:42Z
Lists: pgsql-hackers 
On 13.09.23 16:36, Aleksander Alekseev wrote:
> ```
> +                // FIXME: why 2?
>                   if (set_oldest_commit_ts_xid < 2 &&
> ```
> 
> Should we rewrite this to < FrozenTransactionId ?

That's what I suspect, but we should confirm that.

> 
> ```
> +$mult = 32 * $blcksz * 4; # FIXME
> ```
> 
> Unless I'm missing something this $mult value is not used. Is it
> really needed here?

The FIXME is that I think a multiplier *should* be applied somehow.  See 
also the FIXME in the documentation for the -c option.

Commits

  1. doc: pg_resetwal: Add comments how the multipliers are derived

  2. pg_resetwal: Add more tests and test coverage

  3. More consistent behavior of GetDataDirectoryCreatePerm on Windows

  4. doc: Improve documentation about pg_resetwal -f option

  5. pg_resetwal: Use frontend logging API

  6. pg_resetwal: Regroup --help output

  7. pg_resetwal: Improve error with wrong/missing data directory

  8. pg_resetwal: Update an obsolete comment