Horton

Re: Remove nonmeaningful prefixes in PgStat_* fields

Bertrand Drouvot <bertranddrouvot.pg@gmail.com>

View thread View on postgr.es
From: "Drouvot, Bertrand" <bertranddrouvot.pg@gmail.com>
To: Michael Paquier <michael@paquier.xyz>, Andres Freund <andres@anarazel.de>, Alvaro Herrera <alvherre@alvh.no-ip.org>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2023-03-23T06:51:37Z
Lists: pgsql-hackers

Attachments

Hi,

On 3/23/23 1:09 AM, Michael Paquier wrote:
> On Wed, Mar 22, 2023 at 02:52:23PM -0400, Melanie Plageman wrote:
>> This comment still has the t_ prefix as does the one for tuples_updated
>> and deleted.
>>
>> otherwise, LGTM.
> 
> Good catch.  pgstat_count_heap_update() has a t_tuples_hot_updated,
> and pgstat_update_heap_dead_tuples() a t_delta_dead_tuples on top of
> the three you have just reported.
> 
> I have grepped for all the fields renamed, and nothing else stands
> out.  However, my eyes don't have a 100% accuracy, either.

Thank you both for your keen eye! I just did another check too and did not
find more than the ones you've just reported.

Please find attached V3 getting rid of them.

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

Commits

  1. Rename fields in pgstat structures for functions and relations