Re: Fix REPACK with WITHOUT OVERLAPS replica identity indexes

Chao Li <li.evan.chao@gmail.com>

From: Chao Li <li.evan.chao@gmail.com>

To: Álvaro Herrera <alvherre@kurilemu.de>

Cc: Kirill Reshke <reshkekirill@gmail.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>

Date: 2026-05-12T02:31:05Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Fix REPACK with WITHOUT OVERLAPS replica identity indexes
- 36f52a59b315 19 (unreleased) landed
Remove working test that was supposed to fail
- 2fd787d0aac1 19 (unreleased) cited


> On May 12, 2026, at 00:21, Álvaro Herrera <alvherre@kurilemu.de> wrote:
> 
> On 2026-May-11, Chao Li wrote:
> 
>>> On May 10, 2026, at 06:38, Álvaro Herrera <alvherre@kurilemu.de> wrote:
> 
>>> I think it would be a good idea to make identity_key_equal() not deform
>>> all attributes, but instead only up to the last one it needs for the key
>>> comparisons.
>> 
>> That’s true. Please see v3.
> 
> Thanks.  I did one further small change, namely to determine these last
> attnums just once per run rather than once per tuple.  Pushed now.
> 
> Thanks for testing!
> 
> -- 
> Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/

Hi Álvaro, thank you so much for tuning the code and pushing.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/