Re: replace strtok()

Alexander Law <exclusion@gmail.com>

From: Alexander Lakhin <exclusion@gmail.com>

To: Peter Eisentraut <peter@eisentraut.org>, David Steele <david@pgmasters.net>, Michael Paquier <michael@paquier.xyz>, Tom Lane <tgl@sss.pgh.pa.us>

Cc: Ranier Vilela <ranier.vf@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>

Date: 2024-10-10T05:00:00Z

Lists: pgsql-hackers

Hello Peter,

23.07.2024 15:38, Peter Eisentraut wrote:
> This has been committed.  Thanks.

Please look at the SCRAM secret, which breaks parse_scram_secret(),
perhaps because strsep() doesn't return NULL where strtok() did:

CREATE ROLE r PASSWORD 
'SCRAM-SHA-256$4096:hpFyHTUsSWcR7O9P$LgZFIt6Oqdo27ZFKbZ2nV+=vtnYM995pDh9ca6WSi120qVV5NeluNfUPkwm7Vqat25RjSPLkGeoZBQs6wVv+um4=';

Core was generated by `postgres: law regression [local] CREATE ROLE                                  '.
Program terminated with signal SIGSEGV, Segmentation fault.

#0  __strlen_avx2 () at ../sysdeps/x86_64/multiarch/strlen-avx2.S:74
(gdb) bt
#0  __strlen_avx2 () at ../sysdeps/x86_64/multiarch/strlen-avx2.S:74
#1  0x0000563625e9e5b0 in parse_scram_secret (...) at auth-scram.c:655

Best regards,
Alexander

Commits

Fix memory leaks from incorrect strsep() uses
- 4b652692e979 18.0 landed
Fix strsep() use for SCRAM secrets parsing
- 24a36f91e32d 18.0 landed
Replace remaining strtok() with strtok_r()
- 65504b747f3c 18.0 landed
Windows replacement for strtok_r()
- 4d130b28727c 18.0 landed
Replace some strtok() with strsep()
- 5d2e1cc117b3 18.0 landed
Add port/ replacement for strsep()
- 683be87fbba0 18.0 landed