Re: Allow root ownership of client certificate key
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: David Steele <david@pgmasters.net>
Cc: pgsql-hackers@lists.postgresql.org, Stephen Frost <sfrost@snowman.net>
Date: 2022-01-18T21:51:48Z
Lists: pgsql-hackers
David Steele <david@pgmasters.net> writes: > On 1/18/22 15:41, Tom Lane wrote: >> The only other nitpick I have is that I'd make the cross-references be >> to the two file names, ie like "Note that similar checks are performed >> in fe-secure-openssl.c ..." References to the specific functions seem >> likely to bit-rot in the face of future code rearrangements. >> I suppose filename references could become obsolete too, but it >> seems less likely. > It's true that functions are more likely to be renamed, but when I > rename a function I then search for all the places where it is used so I > can update them. If the function name appears in a comment that gets > updated as well. Harsh experience says that a lot of Postgres contributors have zero interest in updating comments two lines away from what they're editing, let alone in some distant branch of the source tree. But I'm not dead set on it either way. regards, tom lane
Commits
-
Allow root-owned SSL private keys in libpq, not only the backend.
- 9050999efea7 10.21 landed
- 72918ea86cb9 12.11 landed
- 6599d8f12642 13.7 landed
- 5bb3d91ea926 11.16 landed
- 2a1f84636dc3 14.3 landed
- a59c79564bdc 15.0 landed
-
Doc: update libpq.sgml for root-owned SSL private keys.
- 50f03473ed81 15.0 landed