Horton

Re: pg14 psql broke \d datname.nspname.relname

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Mark Dilger <mark.dilger@enterprisedb.com>, Robert Haas <robertmhaas@gmail.com>, Justin Pryzby <pryzby@telsasoft.com>, Stephen Frost <sfrost@snowman.net>, Peter Geoghegan <pg@bowt.ie>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2021-11-05T13:59:42Z
Lists: pgsql-hackers 
Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> I think it would appropriate to normalize identifiers that are going to
> be stored in catalogs.  As presented, this is a bit ridiculous and I see
> no reason to continue to support it.

If we had any sort of convention about the encoding of identifiers stored
in shared catalogs, maybe we could do something about that.  But we don't,
so any change is inevitably going to break someone's use-case.

In any case, that seems quite orthogonal to the question of how to treat
names with too many dots in them.  Considering we are three days out from
freezing 14.1, I think it is time to stop the meandering discussion and
fix it.  And by "fix", I mean revert to the pre-14 behavior.

			regards, tom lane

Commits

  1. Remove some recently-added pg_dump test cases.

  2. Allow db.schema.table patterns, but complain about random garbage.

  3. Improve error handling of HMAC computations

  4. Factor pattern-construction logic out of processSQLNamePattern.