Re: Why do we have perl and sed versions of Gen_dummy_probes?
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@postgresql.org, Andrew Dunstan <andrew@dunslane.net>,
Michael Paquier <michael@paquier.xyz>,
Craig Ringer <craig.ringer@enterprisedb.com>
Date: 2021-05-06T04:18:12Z
Lists: pgsql-hackers
Andres Freund <andres@anarazel.de> writes: > I understand why we don't want to rely on sed because of windows - but > it's far from obvious why we can't just use the .pl variant all the > time? Perl is not considered a hard build requirement on non-Windows. We could dodge that by shipping a pre-built dummy probes.h, but that doesn't really seem like a cleaner way than what's there now. Also, as I read it, Gen_dummy_probes.sed is useful in any case as being the "source code" for Gen_dummy_probes.pl. You'd need some other form of documentation if you removed it. regards, tom lane
Commits
-
Tweak generation of Gen_dummy_probes.pl
- 0bf62931cae0 14.0 landed
-
Add a README and Makefile recipe for Gen_dummy_probes.pl
- 8292c0675a79 14.0 landed
-
Remove dependency on psed for MSVC builds.
- 5d0320105699 9.6.0 cited