Horton

Re: AlterSubscription_refresh "wrconn" wrong variable?

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Peter Smith <smithpb2250@gmail.com>, Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-05-06T21:08:50Z
Lists: pgsql-hackers 
Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> On 2021-May-06, Peter Smith wrote:
>> PSA v3 of the patch. Same as before, but now also renames the global
>> variable from "wrconn" to "lrep_worker_wrconn".

> I think there are two patches here -- the changes to
> AlterSubscription_refresh are a backpatchable bugfix, and the rest of it
> can just be applied to master.

The rename of that variable is just cosmetic, true, but I'd still be
inclined to back-patch it.  If we don't do so then I'm afraid that
future back-patched fixes might be bitten by the same confusion,
possibly introducing new real bugs.

Having said that, keeping the two aspects in separate patches might
ease review and testing.

> In my mind we make a bit of a distinction for global variables by using
> CamelCase rather than undercore_separated_words.

I think it's about 50/50, TBH.  I'd stick with whichever style is
being used in nearby code.

			regards, tom lane

Commits

  1. Rename the logical replication global "wrconn"

  2. AlterSubscription_refresh: avoid stomping on global variable

  3. Logical replication support for initial data copy