Horton

Re: pgsql: Modify pg_dump to use error-free memory allocation macros. This

Tom Lane <tgl@sss.pgh.pa.us>

View thread
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Bruce Momjian <bruce@momjian.us>
Cc: pgsql-committers@postgresql.org
Date: 2011-11-26T07:13:09Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Modify pg_dump to use error-free memory allocation macros. This avoids

Bruce Momjian <bruce@momjian.us> writes:
> Modify pg_dump to use error-free memory allocation macros.  This avoids
> ignoring errors and call-site error checking.

This appears to have broken the MSVC build.  More generally, I'd like to
object to arbitrarily moving a bunch of longstanding code from one file
to another.  What that is mainly going to accomplish is creating a big
headache whenever we have to back-patch fixes that touch that code
... and what exactly did it buy in return?

			regards, tom lane