Thread
Commits
-
Fix comments of GUC hooks for timezone_abbreviations
- f0672b6787ab 16.7 landed
- 67ef403d0e8f 17.3 landed
- d37e856410d0 18.0 landed
-
Fix some comments for GUC hooks of timezone_abbreviations
Michael Paquier <michael@paquier.xyz> — 2024-12-10T01:14:17Z
Hi all, While browsing through the code, I have noticed two comments on top of assign_timezone_abbreviations() and check_timezone_abbreviations() that mention "assign_timezone_abbreviations" as the GUC name, while it should be "timezone_abbreviations", obviously. I have not noticed any similar mistakes for the other check and assign hooks. Comments are welcome. -- Michael
-
Re: Fix some comments for GUC hooks of timezone_abbreviations
Tom Lane <tgl@sss.pgh.pa.us> — 2024-12-10T02:18:48Z
Michael Paquier <michael@paquier.xyz> writes: > While browsing through the code, I have noticed two comments on top of > assign_timezone_abbreviations() and check_timezone_abbreviations() > that mention "assign_timezone_abbreviations" as the GUC name, while it > should be "timezone_abbreviations", obviously. Obvious typo indeed (probably my fault :-() regards, tom lane
-
Re: Fix some comments for GUC hooks of timezone_abbreviations
Michael Paquier <michael@paquier.xyz> — 2024-12-10T03:20:59Z
On Mon, Dec 09, 2024 at 09:18:48PM -0500, Tom Lane wrote: > Obvious typo indeed (probably my fault :-() As a matter of fact, you are right as this comes from 0a20ff54f5e6. No worries, I'll go fix that. -- Michael