Re: assorted code cleanup
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Michael Paquier <michael.paquier@gmail.com>,
pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2017-09-07T18:53:00Z
Lists: pgsql-hackers
Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes: > On 9/5/17 15:32, Tom Lane wrote: >> I do agree with the idea that we should use the * notation in cases where >> the reader might otherwise think that a plain function was being invoked, >> ie I don't like >> some_function_pointer(args); >> Even if the compiler isn't confused, readers might be. But in the case of >> structname->pointerfield(args); >> it's impossible to read that as a plain function call, so I'm okay with >> dropping the extra punctuation there. > Committed that way. Thanks. Is it worth memorializing this in the docs somewhere, perhaps "53.4. Miscellaneous Coding Conventions" ? regards, tom lane
Commits
-
Reduce excessive dereferencing of function pointers
- 1356f78ea933 11.0 landed