Horton

Re: BUG #18247: Integer overflow leads to negative width

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Richard Guo <guofenglinux@gmail.com>
Cc: Junwang Zhao <zhjwpku@gmail.com>, rekgrpth@gmail.com, pgsql-bugs@lists.postgresql.org
Date: 2023-12-19T04:08:57Z
Lists: pgsql-bugs 
Richard Guo <guofenglinux@gmail.com> writes:
> I agree with all the comments made.  I have also examined other places
> where the width field is assigned, and I think we've covered all cases.
> So the v3 patch is in good shape to me.

Thanks for looking!  Do you have an opinion about the int64-vs-double
question?

			regards, tom lane

Commits

  1. Prevent integer overflow when forming tuple width estimates.

  2. compute_bitmap_pages' loop_count parameter should be double not int.