Re: Making background psql nicer to use in tap tests

Daniel Gustafsson <daniel@yesql.se>

From: Daniel Gustafsson <daniel@yesql.se>

To: Andres Freund <andres@anarazel.de>

Cc: Andrew Dunstan <andrew@dunslane.net>, Tom Lane <tgl@sss.pgh.pa.us>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>, Melanie Plageman <melanieplageman@gmail.com>, Amit Kapila <amit.kapila16@gmail.com>, mikael.kjellstrom@gmail.com

Date: 2023-04-07T21:01:47Z

Lists: pgsql-hackers

> On 7 Apr 2023, at 22:24, Daniel Gustafsson <daniel@yesql.se> wrote:
> 
>> On 7 Apr 2023, at 18:14, Daniel Gustafsson <daniel@yesql.se> wrote:
>>> On 7 Apr 2023, at 17:04, Andres Freund <andres@anarazel.de> wrote:
> 
>>> Afaict the failures are purely about patch 2, not 1, right?
>> 
>> Correct.  The attached v6 wraps the interactive_psql test in a SKIP block with
>> a conditional on IO::Pty being available.
> 
> This version was green in the CFBot, so I ended up pushing it after some
> documentation fixups and polish.

Looks like morepork wasn't happy with the interactive \password test.

https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=morepork&dt=2023-04-07%2020%3A30%3A29

Looking into why the timer timed out in that test.

--
Daniel Gustafsson

Commits

Fix missing installation/uninstallation rules for BackgroundPsql.pm
- 241ef53b6a95 12.20 landed
- 0d80e59a1b2c 13.16 landed
- 1185be355462 14.13 landed
- 9d7506a2f7cb 15.8 landed
Backport BackgroundPsql perl test module
- 4b467a6581af 12.20 landed
- 12f327b210b3 13.16 landed
- 31877cd8ec8c 14.13 landed
- d5fd7865f068 15.8 landed
- 187b8991f70f 16.4 landed
Add missing uninstallation rule for BackgroundPsql.pm
- 7039c7cff673 16.0 cited
Fix missing installation rules for BackgroundPsql.pm
- a4c17c86176c 16.0 cited
Skip \password TAP test on old IPC::Run versions
- 2e57ffe12f6b 16.0 landed
Test SCRAM iteration changes with psql \password
- bf5a894c5571 16.0 landed
Refactor background psql TAP functions
- 664d757531e1 16.0 landed