Horton

Re: Adding CommandID to heap xlog records

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Matthias van de Meent <boekewurm+postgres@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>, Heikki Linnakangas <hlinnaka@iki.fi>
Date: 2022-09-08T21:24:57Z
Lists: pgsql-hackers 
Matthias van de Meent <boekewurm+postgres@gmail.com> writes:
> Please find attached a patch that adds the CommandId of the inserting
> transaction to heap (batch)insert, update and delete records. It is
> based on the changes we made in the fork we maintain for Neon.

This seems like a very significant cost increment with returns
to only a minuscule number of users.  We certainly cannot consider
it unless you provide some evidence that that impression is wrong.

			regards, tom lane

Commits

  1. Remove redundant check for fast_forward.

  2. Improve comment on why we need ctid->(cmin,cmax) mapping.