Re: "unix_socket_directories" should be GUC_LIST_INPUT?

Peter Eisentraut <peter.eisentraut@2ndquadrant.com>

From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Michael Paquier <michael@paquier.xyz>, Tom Lane <tgl@sss.pgh.pa.us>
Cc: Ian Lawrence Barwick <barwick@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2020-10-27T10:42:28Z
Lists: pgsql-hackers
On 2020-10-23 10:02, Michael Paquier wrote:
>> So maybe we could get away with just changing it.  It'd be good to
>> verify though that this doesn't break existing string values for
>> the variable, assuming they contain no unlikely characters that'd
>> need quoting.
> 
> Yeah, that's the kind of things I wanted to check anyway before
> considering doing the switch.

If we're going to change it I think we need an updated patch that covers 
pg_dump.  (Even if we argue that pg_dump would not normally dump this 
variable, keeping it up to date with respect to GUC_LIST_QUOTE seems 
proper.)

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



Commits

  1. Add GUC_LIST_INPUT and GUC_LIST_QUOTE to unix_socket_directories