Re: pg_dump --with-* options

On Tue, 2025-07-29 at 11:24 -0700, Jeff Davis wrote:
> On Wed, 2025-06-18 at 10:21 -0700, Jeff Davis wrote:
> > On Wed, 2025-06-18 at 10:43 -0500, Nathan Bossart wrote:
> > > IIUC the current proposal is to:
> > > 
> > > * Dump/restore stats by default.
> 
> We don't have a consensus for that, so unless a few people make an
> abrupt turnaround, this will remain off for v18.
> 
> > > * Keep the --no-statistics, --no-schema, and --no-data options.
> > > * Keep the --statistics-only, --schema-only, and --data-only
> > > options.
> > > * Remove the --with-statistics, --with-schema, and --with-data
> > > options.
> 
> The other parts of the proposal are very similar with mine below:
> 
> >   * delete the --with-data and --with-schema options as unnecessary
> >   * (maybe?) rename --with-statistics to --statistics
> >   * keep --no-statistics, --no-data, --no-schema (or use "without"
> > instead?)
> >   * (maybe?) keep --statistics-only
> >   * reject the combination of an "only" option and a "with" option

Patch attached.

  * removes --with-data and --with-schema (redundant)
  * renames --with-statistics to just --statistics

I kept --statistics and --no-statistics for both pg_dump and
pg_restore, because: (a) I think it's good to have consistent options
between those two programs; and (b) it allows us to potentially change
the default to include statistics in the future. That leaves some
redundancy of the options, which some have expressed annoyance over,
but it doesn't seem like a major point of objection.

Regards,
	Jeff Davis