Re: Documentation: 21.5. Default Roles

On 4/28/20 2:19 PM, Magnus Hagander wrote:
> On Sat, Apr 25, 2020 at 1:38 AM Jonathan S. Katz <jkatz@postgresql.org
> <mailto:jkatz@postgresql.org>> wrote:
> 
>     On 4/9/20 11:45 PM, Bruce Momjian wrote:
>     > On Thu, Apr  9, 2020 at 08:47:56PM -0400, Jonathan Katz wrote:
>     >> On 4/9/20 4:57 PM, Bruce Momjian wrote:
>     >>> Jonathan, Stephen, with the minor release done, can we focus on
>     adding
>     >>> the URL redirect and completing the patch to rename this feature
>     in the
>     >>> docs?  Thanks.
>     >>
>     >> Yes, I have a prototype for this ready, which I had scrambled
>     together
>     >> before the release. I am happy to make it committable in the
>     coming days.
>     >
>     > Thanks.  Once that is done Stephen can apply my patch with his
>     > additions.
> 
>     Please see attached patch for pgweb that allows for the documentation to
>     be redirected from a page that is removed to a newer page. The way
>     it works:
> 
>     - Checks to see if a page is found. If it is, great!
>     - Now if a page 404s, we first check to see if there is a forwarding
>     address, i.e. the new page. If it is, we issue a 301 (permanent
>     redirecTt).
>     - If it's still not found, we abort.
> 
>     I believe this gives us the desired behavior.
> 
>     Thoughts on the patch?
> 
> 
>  Looks good to me. Go for it.

This is deployed. Ready for the patch in core.

Thanks!

Jonathan