Re: [HACKERS] Time to change pg_regress diffs to unified by default?
Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Christoph Berg <myon@debian.org>,
Andrew Gierth <andrew@tao11.riddles.org.uk>,
Daniel Gustafsson <daniel@yesql.se>, Noah Misch <noah@leadboat.com>,
Tom Lane <tgl@sss.pgh.pa.us>, Andres Freund <andres@anarazel.de>,
pgsql-hackers@postgresql.org
Date: 2019-02-20T10:22:23Z
Lists: pgsql-hackers
On 2019-02-15 16:05, Christoph Berg wrote: > Re: Andrew Gierth 2019-02-15 <874l95m8w7.fsf@news-spur.riddles.org.uk> >> Also while we're tweaking regression test output, would it be possible >> to have some indicator of whether a test passed because a variant file >> in the resultmap was ignored in favor of the standard result? >> >> The current system of silently ignoring the resultmap means that nobody >> ever notices when resultmap entries become obsolete.... > > By the same argument, it should always print which variant file was > used so determining which _N.out files are still in use is possible. I would rather not overload the test output even more. A test passes or it doesn't. If we need to collect additional information, let's think about ways to do that separately. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Commits
-
pg_regress: Don't use absolute paths for the diff
- 1995552deb54 12.0 landed
-
Use standard diff separator for regression.diffs
- 8f27a14b1bd3 12.0 landed