Re: SSL tests fail on OpenSSL v3.2.0
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: Tristan Partin <tristan@neon.tech>,
Nazir Bilal Yavuz <byavuz81@gmail.com>,
Andres Freund <andres@anarazel.de>, Bo Anderson <mail@boanderson.me>,
pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2023-11-28T00:21:03Z
Lists: pgsql-hackers
Michael Paquier <michael@paquier.xyz> writes: > Interesting. I have yet to look at that in details, but > BIO_get_app_data() exists down to 0.9.8, which is the oldest version > we need to support for stable branches. So that looks like a safe > bet. What about LibreSSL? In general, I'm not too pleased with just assuming that BIO_get_app_data exists. If we can do that, we can probably remove most of the OpenSSL function probes that configure.ac has today. Even if that's a good idea in HEAD, I doubt we want to do it all the way back. I'd be inclined to form the patch more along the lines of s/BIO_get_data/BIO_get_app_data/g, with a configure check for BIO_get_app_data and falling back to the existing direct use of bio->ptr if it's not there. regards, tom lane
Commits
-
Use BIO_{get,set}_app_data instead of BIO_{get,set}_data.
- efb804682719 13.14 landed
- efa8f606402c 16.2 landed
- c82207a548db 17.0 landed
- b2b1f12882fb 14.11 landed
- 5dd30bb54bfe 15.6 landed
- 0bd682246a61 12.18 landed