Horton

Re: more descriptive message for process termination due to max_slot_wal_keep_size

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: bdrouvot@amazon.com, sawada.mshk@gmail.com, ashutosh.bapat.oss@gmail.com, pgsql-hackers@postgresql.org
Date: 2022-09-28T20:38:51Z
Lists: pgsql-hackers 
... oh, one other point is that using %ld to print an int64 is entirely
not portable, as indeed the cfbot is complaining about.

I think our best practice on that is to put %lld in the format string
and explicitly cast the corresponding argument to "long long".

			regards, tom lane

Commits

  1. Improve wording of log messages triggered by max_slot_wal_keep_size.