Re: Fix pg_publication_tables to exclude generated columns
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: "shiy.fnst@fujitsu.com" <shiy.fnst@fujitsu.com>,
PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2023-01-09T15:06:12Z
Lists: pgsql-hackers
Amit Kapila <amit.kapila16@gmail.com> writes: > On Mon, Jan 9, 2023 at 5:29 PM shiy.fnst@fujitsu.com > <shiy.fnst@fujitsu.com> wrote: >> I think one way to fix it is to modify pg_publication_tables query to exclude >> generated columns. But in this way, we need to bump catalog version when fixing >> it in back-branch. Another way is to modify function >> pg_get_publication_tables()'s return value to contain all supported columns if >> no column list is specified, and we don't need to change system view. > That sounds like a reasonable approach to fix the issue. We could just not fix it in the back branches. I'd argue that this is as much a definition change as a bug fix, so it doesn't really feel like something to back-patch anyway. regards, tom lane
Commits
-
Ignore dropped and generated columns from the column list.
- b7ae03953690 16.0 landed