Re: pg_stop_backup does not complete
Greg Stark <gsstark@mit.edu>
From: Greg Stark <gsstark@mit.edu>
To: Simon Riggs <simon@2ndquadrant.com>
Cc: Fujii Masao <masao.fujii@gmail.com>, Bruce Momjian <bruce@momjian.us>, jd@commandprompt.com, Josh Berkus <josh@agliodbs.com>, Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2010-03-02T13:13:37Z
Lists: pgsql-hackers
On Tue, Mar 2, 2010 at 9:48 AM, Simon Riggs <simon@2ndquadrant.com> wrote: >> > Setting archive_mode to a command that does nothing but return true, e.g. /bin/true, >> >> "return true" seems ambiguous for me. How about writing clearly >> "return a zero exit status" instead? > > Docs are already quite clear on that point. I think we should avoid > specifying it twice. > Why do we disallow turning off archive_mode anyways? I understand not turning it on -- though even that would be nice if it "took effect after the next checkpoint" but turning it off should always be safe, no? -- greg