Re: create subscription - improved warning message

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Smith <smithpb2250@gmail.com>
Cc: Amit Kapila <amit.kapila16@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2022-10-10T14:44:41Z
Lists: pgsql-hackers
Peter Smith <smithpb2250@gmail.com> writes:
> On Mon, Oct 10, 2022 at 4:04 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
>> I think the below gives accurate information:
>> WARNING: subscription was created, but is not connected
>> HINT: You should create the slot manually, enable the subscription,
>> and run %s to initiate replication.

> +1

It feels a little strange to me that we describe two steps rather vaguely
and then give exact SQL for the third step.  How about, say,

HINT: To initiate replication, you must manually create the replication
slot, enable the subscription, and refresh the subscription.

Another idea is

HINT: To initiate replication, create the replication slot on the
publisher, then run ALTER SUBSCRIPTION ... ENABLE and ALTER
SUBSCRIPTION ... REFRESH PUBLICATION.

			regards, tom lane



Commits

  1. Doc: Update information about manually creating slots.

  2. Improve the WARNING message for CREATE SUBSCRIPTION.