Re: Old BufferDesc refcount in PrintBufferDescs and PrintPinnedBufs
Andres Freund <andres@anarazel.de>
From: Andres Freund <andres@anarazel.de>
To: Michael Paquier <michael@paquier.xyz>
Cc: Jacob Brazeal <jacob.brazeal@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers@postgresql.org
Date: 2025-01-19T18:10:43Z
Lists: pgsql-hackers
Hi, On 2025-01-19 09:37:54 +0900, Michael Paquier wrote: > On Fri, Jan 17, 2025 at 11:14:02PM -0800, Jacob Brazeal wrote: > > Sounds good! v3 attached. > > Removal sounds good to me. Any objections from anybody? > > Andres, perhaps you have some experience using that and would prefer > keep them and make them work? I think they're pretty useless, tbh. There's too many buffers that just printing them out is helpful - pg_buffercache is going to be a better bet. When debugging issues where pg_buffercache isn't an option (e.g. because it's a hang that doesn't allow running pg_buffercache), using DebugPrintBufferRefcount() is much more targeted. Greetings, Andres Freund
Commits
-
Remove PrintBufferDescs() and PrintPinnedBufs().
- 23d7562018b2 18.0 landed