Re: kerberos/001_auth test fails on arm CPU darwin

Nazir Bilal Yavuz <byavuz81@gmail.com>

From: Nazir Bilal Yavuz <byavuz81@gmail.com>

To: Tom Lane <tgl@sss.pgh.pa.us>, Andres Freund <andres@anarazel.de>

Cc: Michael Paquier <michael@paquier.xyz>, Peter Eisentraut <peter.eisentraut@enterprisedb.com>, pgsql-hackers@lists.postgresql.org

Date: 2022-09-27T15:35:45Z

Lists: pgsql-hackers

Attachments

v2-0001-ci-Add-arm-CPU-for-darwin.patch (text/plain) patch v2-0001
v2-0002-fix-darwin-ARM-CPU-darwin-krb5-path-fix.patch (text/plain) patch v2-0002

Hi,

Thanks for the reviews!

On 9/27/2022 5:21 AM, Tom Lane wrote:
> Andres Freund <andres@anarazel.de> writes:
>> Maybe we should rely on PATH, rather than hardcoding OS dependent locations?
> My suggestion to consult krb5-config first was meant to allow PATH
> to influence the results.  However, if that doesn't work, it's important
> IMO to have a sane list of hardwired places to look in.

I updated my patch regarding these reviews.

The current logic is it will try to find all executables in that 
order(if it finds all executables, it won't try remaining steps):

1 - 'krb5-config --prefix'

2 - hardcoded paths(I added arm and MacPorts paths for darwin)

3 - from PATH

Also, I tried to do some refactoring for adding another paths to search 
in the future and being sure about all executables are found.

Ci run after fix is applied:
https://cirrus-ci.com/build/5758254918664192

Regards,
Nazir Bilal Yavuz