Horton

Thread

Commits

  1. Fix incorrect xmlschema output for types timetz and timestamptz.

  1. [PATCH] Add support to table_to_xmlschema regex when timestamp has time zone

    Renan Soares Lopes <renans.l@icloud.com> — 2022-02-18T17:47:14Z

    Hello,I added a patch to fix table_to_xmlschema, could you point me how to add a unit test to that?

  2. Re: [PATCH] Add support to table_to_xmlschema regex when timestamp has time zone

    Euler Taveira <euler@eulerto.com> — 2022-02-18T19:10:36Z

    On Fri, Feb 18, 2022, at 2:47 PM, Renan Soares Lopes wrote:
> Hello,
> 
> I added a patch to fix table_to_xmlschema, could you point me how to add a unit test to that?
You should edit src/test/regress/expected/xmlmap.out. In this case, you should
also modify src/test/regress/expected/xmlmap_1.out that the output from this
test when you build without libxml support. Run 'make check' to test your fix
after building with/without libxml support.

Regarding this fix, it looks good to me. FWIW, character class escape is
defined here [1].

[1] https://www.w3.org/TR/xmlschema11-2/#cces


--
Euler Taveira
EDB   https://www.enterprisedb.com/

  3. Re: [PATCH] Add support to table_to_xmlschema regex when timestamp has time zone

    Tom Lane <tgl@sss.pgh.pa.us> — 2022-03-18T20:02:49Z

    "Euler Taveira" <euler@eulerto.com> writes:
> On Fri, Feb 18, 2022, at 2:47 PM, Renan Soares Lopes wrote:
>> I added a patch to fix table_to_xmlschema, could you point me how to add a unit test to that?

> You should edit src/test/regress/expected/xmlmap.out. In this case, you should
> also modify src/test/regress/expected/xmlmap_1.out that the output from this
> test when you build without libxml support. Run 'make check' to test your fix
> after building with/without libxml support.

> Regarding this fix, it looks good to me. FWIW, character class escape is
> defined here [1].

LGTM too.  Pushed after rethinking the test case a bit.

			regards, tom lane