Horton

Re: BUG #16780: Inconsistent recovery_target_xid handling across platforms

Alexander Law <exclusion@gmail.com>

View thread View on postgr.es
From: Alexander Lakhin <exclusion@gmail.com>
To: Michael Paquier <michael@paquier.xyz>, pgsql-bugs@lists.postgresql.org
Date: 2020-12-23T06:00:00Z
Lists: pgsql-bugs 
23.12.2020 07:44, Michael Paquier wrote:
> On Tue, Dec 22, 2020 at 02:02:46PM +0900, Michael Paquier wrote:
>> So, attached is a patch to make the logic more consistent that I would
>> like to apply down to 12.  Please let me know if there are any
>> objections or comments.
> I have looked at that again this morning, and applied a fix down to
> 9.6 with the change in the TAP tests based on pg_resetwal.  In 9.5,
> pg_strtouint64() is not available, but this branch is old enough that
> it did not seem worth the extra effort.
Thank you!
I think that with this change, if the check for epoch will be added
someday, it will work consistently too.

Best regards,
Alexander

Commits

  1. Fix portability issues with parsing of recovery_target_xid