Horton

Re: TEMP_CONFIG vs test_aio

Andrew Dunstan <andrew@dunslane.net>

View thread
From: Andrew Dunstan <andrew@dunslane.net>
To: Andres Freund <andres@anarazel.de>, Todd Cook <cookt@blackduck.com>
Cc: "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>, Noah Misch <noah@leadboat.com>
Date: 2025-04-01T21:08:49Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. tests: Cope with io_method in TEMP_CONFIG in test_aio

  2. aio: Add test_aio module

On 2025-04-01 Tu 4:17 PM, Andres Freund wrote:
> Hi,
>
> On 2025-04-01 20:12:29 +0000, Todd Cook wrote:
>> On 4/1/25, 3:42 PM, "Andres Freund" <andres@anarazel.de <mailto:andres@anarazel.de>> wrote:
>>> I just committed the tests for AIO, and unfortunately they (so far) fail on
>>> one buildfarm animal:
>>> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=bumblebee&dt=2025-04-01%2018%3A55%3A01 <https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=bumblebee&amp;dt=2025-04-01%2018%3A55%3A01>
>>>
>>> The reason for the failure is simple, the buildfarm animal specifies
>>> io_method=io_uring (thanks to "cookt" for setting that up so quickly, whoever
>>> you are :)) and the test is assuming that the -c io_method=... it passes to
>>> initdb is actually going to be used, but it's overwritten by the TEMP_CONFIG.
>> You're welcome!
>>
>> Is there an alternate way I could use to configure the io_method on bumblebee?
> You could use PG_TEST_INITDB_EXTRA_OPTS, but I think you did it the right
> way.
>
> For one using PG_TEST_INITDB_EXTRA_OPTS would probably require changing the
> buildfarm code, because the buildfarm code filters out environment variables
> that aren't on an allowlist (I really dislike that).


Uh, not quite. Anything in the config's build_env is not filtered out. 
That change was made a year ago.


cheers


andrew

--
Andrew Dunstan
EDB:https://www.enterprisedb.com