Horton
Menu

Re: Update LDAP Protocol in fe-connect.c to v3

Peter Eisentraut <peter@eisentraut.org>

View thread
From: Peter Eisentraut <peter@eisentraut.org>
To: Andrew Jackson <andrewjackson947@gmail.com>
Cc: Pavel Seleznev <pavel.seleznev@gmail.com>, pgsql-hackers@lists.postgresql.org
Date: 2025-08-12T15:36:52Z
Lists: pgsql-hackers 
On 23.05.25 13:51, Peter Eisentraut wrote:
> On 15.05.25 14:54, Pavel Seleznev wrote:
>> I applied your patch. I ran extended application tests relative to 
>> vanilla ones, which include various scenarios of working with LDAP and 
>> I think that we can safely apply the patch in the PG18.
>>
>> I did not see the need for additional LDAP tests, since compatibility 
>> is provided by the LDAP library itself,  and not by the Postgres code. 
>> Also  protocol version 3 has been published for quite a long time 
>> (more than 20 years) and real use by clients is through version 3
> 
> FWIW, I'm prepared to commit this, but not for PG 18 at this point.

I have looked at this patch again.  There is a CI failure on Windows, 
and I was also able to reproduce this in my own CI runs, so it's not 
just a fluke.

https://cirrus-ci.com/task/6576976439279616?logs=build#L1271

The whole thing is puzzling, since we use the same code in the backend, 
without any Windows-specific guards.  No clue.

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Add TAP tests for LDAP connection parameter lookup

  2. libpq: Set LDAP protocol version 3