Horton

Re: doc: modify the comment in function libpqrcv_check_conninfo()

Rintaro Ikeda <ikedarintarof@oss.nttdata.com>

View thread View on postgr.es
From: ikedarintarof <ikedarintarof@oss.nttdata.com>
To: Fujii Masao <masao.fujii@oss.nttdata.com>
Cc: Jelte Fennema-Nio <postgres@jeltef.nl>, Robert Haas <robertmhaas@gmail.com>, pgsql-hackers@postgresql.org
Date: 2024-07-09T06:56:34Z
Lists: pgsql-hackers

Attachments

> - * Validate connection info string, and determine whether it might 
> cause
> - * local filesystem access to be attempted.
> + * The function
> + * 1. validates connection info string and
> + * 2. checks a password is provided if must_use_password is true.
> 
> IMO, "Validate connection info string" is sufficient. The mention of
> must_use_password is redundant since it's explained in the latter part 
> of
> the comment.

That is reasonable for me. I've removed the second one.
The modified patch is attached.

Regards,

Rintaro Ikeda

Commits

  1. Fix comment in libpqrcv_check_conninfo().