Horton

Re: Fix around conn_duration in pgbench

Fujii Masao <masao.fujii@oss.nttdata.com>

View thread View on postgr.es
From: Fujii Masao <masao.fujii@oss.nttdata.com>
To: Yugo NAGATA <nagata@sraoss.co.jp>
Cc: Asif Rehman <asifr.rehman@gmail.com>, pgsql-hackers@lists.postgresql.org, Fabien COELHO <coelho@cri.ensmp.fr>
Date: 2021-08-05T07:16:48Z
Lists: pgsql-hackers 

On 2021/08/01 14:50, Yugo NAGATA wrote:
> When -C is not specified, the disconnection time is not measured even in
> the patch for v14+. I don't think it is a problem because the
> disconnection delay at the end of benchmark almost doesn't affect the tps.

What about v13 or before? That is, in v13, even when -C is not specified,
both the connection and disconnection delays are measured. Right?
If right, the time required to close the connection in CSTATE_FINISHED
state should also be measured?

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

Commits

  1. pgbench: Fix bug in measurement of disconnection delays.

  2. pgbench: Avoid unnecessary measurement of connection delays.

  3. pgbench: Improve time logic.