Horton

Re: Fix output of zero privileges in psql

Laurenz Albe <laurenz.albe@cybertec.at>

View thread View on postgr.es
From: Laurenz Albe <laurenz.albe@cybertec.at>
To: Shubham Khanna <khannashubham1197@gmail.com>
Cc: Erik Wienhold <ewie@ewie.name>, "David G. Johnston" <david.g.johnston@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2023-11-08T12:23:28Z
Lists: pgsql-hackers 
On Wed, 2023-11-08 at 10:56 +0530, Shubham Khanna wrote:
> I tested the Patch for the modified changes and it is working fine.

Thanks for the review!

I wonder how to proceed with this patch.  The main disagreement is
whether default privileges should be displayed as NULL (less invasive,
but more confusing for beginners) or "(default)" (more invasive,
but nicer for beginners).

David is for "(default)", Tom and me are for NULL, and I guess Erik
would also prefer "(default)", since that was how his original
patch did it, IIRC.  I think I could live with both solutions.

Kind of a stalemate.  Who wants to tip the scales?

Yours,
Laurenz Albe

Commits

  1. Improve default and empty privilege outputs in psql.