Re: [PATCH] improve the pg_upgrade error message

On Mon, 2021-07-12 at 16:58 +0530, Jeevan Ladhe wrote:
> While looking into one of the pg_upgrade issue, I found it
> challenging to find out the database that has the datallowconn set to
> 'false' that was throwing following error:
> 
> "All non-template0 databases must allow connections, i.e. their pg_database.datallowconn must be true"
> 
> It can be argued that we can query the pg_database
> catalog and find that out easily, but at times it is challenging to get
> that from the customer environment.
>
> With attached patch, now I get following error:
> "All non-template0 databases must allow connections, i.e. their pg_database.datallowconn must be true; database "mydb" has datallowconn set to false."

I am in favor of that in principle, but I think that additional information
should be separate line.

Yours,
Laurenz Albe