Re: Function to promote standby servers
Laurenz Albe <laurenz.albe@cybertec.at>
From: Laurenz Albe <laurenz.albe@cybertec.at>
To: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2018-10-08T17:36:50Z
Lists: pgsql-hackers
Attachments
- 0001-Add-pg_promote-to-promote-standby-servers-V3.patch (text/x-patch) patch 0001
Masahiko Sawada wrote: > Maybe the patch needs regression tests for the new function. And I'd > suggest to make the function name more clear by changing to > pg_promote_server(), pg_promote_standby() and so on. Thanks for the review. The attached patch has regression tests - I though it would be good to change some of the existing tests that run standby promotion to use the SQL function instead of pg_ctl. I have left the name though -- as far as I can tell, "promote" has no other meaning in PostgreSQL than standby promotion, and I believe it is only good to be more verbose if that avoids confusion. Yours, Laurenz Albe
Commits
-
Rework documentation of pg_promote
- 74171f8c12e6 12.0 landed
-
Add pg_promote function
- 10074651e335 12.0 landed