Horton

Thread

Commits

  1. Update comment for Cardinality typedef

  1. Update the comment in nodes.h to cover Cardinality

    Richard Guo <guofenglinux@gmail.com> — 2023-12-19T06:23:25Z

    By chance I discovered that the comment for the typedefs of "double"s
does not cover Cardinality.  Should we update that comment accordingly,
maybe something like below?

- * Typedefs for identifying qualifier selectivities and plan costs as such.
- * These are just plain "double"s, but declaring a variable as Selectivity
- * or Cost makes the intent more obvious.
+ * Typedefs for identifying qualifier selectivities, plan costs and
+ * estimated rows or other count as such.  These are just plain "double"s,
+ * but declaring a variable as Selectivity, Cost or Cardinality makes the
+ * intent more obvious.

Thanks
Richard

  2. Re: Update the comment in nodes.h to cover Cardinality

    Peter Eisentraut <peter@eisentraut.org> — 2023-12-19T14:50:37Z

    On 19.12.23 07:23, Richard Guo wrote:
> By chance I discovered that the comment for the typedefs of "double"s
> does not cover Cardinality.  Should we update that comment accordingly,
> maybe something like below?
> 
> - * Typedefs for identifying qualifier selectivities and plan costs as such.
> - * These are just plain "double"s, but declaring a variable as Selectivity
> - * or Cost makes the intent more obvious.
> + * Typedefs for identifying qualifier selectivities, plan costs and
> + * estimated rows or other count as such.  These are just plain "double"s,
> + * but declaring a variable as Selectivity, Cost or Cardinality makes the
> + * intent more obvious.

Fixed, thanks.

  3. Re: Update the comment in nodes.h to cover Cardinality

    Richard Guo <guofenglinux@gmail.com> — 2023-12-20T00:39:52Z

    On Tue, Dec 19, 2023 at 10:50 PM Peter Eisentraut <peter@eisentraut.org>
wrote:

> On 19.12.23 07:23, Richard Guo wrote:
> > By chance I discovered that the comment for the typedefs of "double"s
> > does not cover Cardinality.  Should we update that comment accordingly,
> > maybe something like below?
> >
> > - * Typedefs for identifying qualifier selectivities and plan costs as
> such.
> > - * These are just plain "double"s, but declaring a variable as
> Selectivity
> > - * or Cost makes the intent more obvious.
> > + * Typedefs for identifying qualifier selectivities, plan costs and
> > + * estimated rows or other count as such.  These are just plain
> "double"s,
> > + * but declaring a variable as Selectivity, Cost or Cardinality makes
> the
> > + * intent more obvious.
>
> Fixed, thanks.


Thanks for the fix!

Thanks
Richard