Re: [PATCH] Completed unaccent dictionary with many missing characters

Przemysław Sztoch <przemyslaw@sztoch.pl>

From: Przemysław Sztoch <przemyslaw@sztoch.pl>
To: Michael Paquier <michael@paquier.xyz>
Cc: Thomas Munro <thomas.munro@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Date: 2022-07-03T20:51:56Z
Lists: pgsql-hackers

Attachments

Michael Paquier wrote on 6/28/2022 7:14 AM:
> On Thu, Jun 23, 2022 at 02:10:42PM +0200, Przemysław Sztoch wrote:
>> The only division that is probably possible is the one attached.
> Well, the addition of cyrillic does not make necessary the removal of
> SOUND RECORDING COPYRIGHT or the DEGREEs, that implies the use of a
> dictionnary when manipulating the set of codepoints, but that's me
> being too picky.  Just to say that I am fine with what you are
> proposing here.
>
> By the way, could you add a couple of regressions tests for each
> patch with a sample of the characters added?  U+210C is a particularly
> sensitive case, as we should really make sure that it maps to what we
> want even if Latin-ASCII.xml tells a different story.  This requires
> the addition of a couple of queries in unaccent.sql with the expected
> output updated in unaccent.out.
> --
> Michael
Regression tests has been added.
-- 
Przemysław Sztoch | Mobile +48 509 99 00 66

Commits

  1. Simplify a bit the special rules generating unaccent.rules