Horton

Re: Vacuum statistics

Alena Rybakina <a.rybakina@postgrespro.ru>

View thread
From: Alena Rybakina <a.rybakina@postgrespro.ru>
To: Kirill Reshke <reshkekirill@gmail.com>
Cc: Jim Nasby <jnasby@upgrade.com>, Andrei Zubkov <zubkov@moonset.ru>, Alexander Korotkov <aekorotkov@gmail.com>, Masahiko Sawada <sawada.mshk@gmail.com>, Melanie Plageman <melanieplageman@gmail.com>, jian he <jian.universality@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>, a.lepikhov@postgrespro.ru
Date: 2024-12-02T20:59:58Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Move wal_buffers_full from PgStat_PendingWalStats to WalUsage

Hi! Thank you for your review!

On 30.11.2024 07:48, Kirill Reshke wrote:
> Hello!
> After a brief glance, I think this patch set is good.
> But there isn't any more time in the current CF to commit this :(.
> So I moved to the next CF.
I agree with you. Thank you!)
> I also like the 0001 commit message. This commit message is quite
> large and easy to understand. Actually, it might be too big. Perhaps
> rather of being a commit message, the final paragraph (pages_frozen -
> number of pages that..) need to be a part of the document. Perhaps
> delete the explanation on pages_frozen that we have in 0004?
To be honest, I don't quite understand what you're suggesting. Are you 
suggesting moving the explanation about the pages_frozen from the commit 
message to the documentation or fixing something in the documentation 
about the pages_frozen? Can you please explain?

-- 
Regards,
Alena Rybakina
Postgres Professional