Horton

Re: Failure in contrib test _int on loach

Teodor Sigaev <teodor@sigaev.ru>

View thread View on postgr.es
From: Teodor Sigaev <teodor@sigaev.ru>
To: Anastasia Lubennikova <a.lubennikova@postgrespro.ru>, Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@lists.postgresql.org, Heikki Linnakangas <hlinnaka@iki.fi>
Date: 2019-04-30T16:32:35Z
Lists: pgsql-hackers 
Hi!

> So, if other hackers are agreed with my reasoning, the suggested fix is 
> sufficient and can be committed.
> 

Patch looks right, but I think that comment should be improved in follow piece:

         if (stack->blkno != GIST_ROOT_BLKNO &&
-           stack->parent->lsn < GistPageGetNSN(stack->page))
+           ((stack->parent->lsn < GistPageGetNSN(stack->page)) ||
+            stack->retry_from_parent == true))
         {
             /*
              * Concurrent split detected. There's no guarantee that the
		....
Not only concurrent split could be deteced here and it was missed long ago. But 
this patch seems a good chance to change this comment.

-- 
Teodor Sigaev                                   E-mail: teodor@sigaev.ru
                                                    WWW: http://www.sigaev.ru/

Commits

  1. Detect internal GiST page splits correctly during index build.

  2. Generate less WAL during GiST, GIN and SP-GiST index build.