Re: Collation & ctype method table, and extension hooks

Jeff Davis <pgsql@j-davis.com>

From: Jeff Davis <pgsql@j-davis.com>

To: Andreas Karlsson <andreas@proxel.se>, pgsql-hackers@postgresql.org

Date: 2024-12-03T07:58:36Z

Lists: pgsql-hackers

Attachments

v10-0001-Move-check-for-ucol_strcollUTF8-to-pg_locale_icu.patch (text/x-patch) patch v10-0001
v10-0002-Move-code-for-collation-version-into-provider-sp.patch (text/x-patch) patch v10-0002
v10-0003-Move-ICU-database-encoding-check-into-validation.patch (text/x-patch) patch v10-0003
v10-0004-Move-provider-specific-code-when-looking-up-loca.patch (text/x-patch) patch v10-0004
v10-0005-Refactor-case-mapping-into-provider-specific-fil.patch (text/x-patch) patch v10-0005
v10-0006-Control-collation-behavior-with-a-method-table.patch (text/x-patch) patch v10-0006
v10-0007-Control-ctype-behavior-internally-with-a-method-.patch (text/x-patch) patch v10-0007
v10-0008-Remove-provider-field-from-pg_locale_t.patch (text/x-patch) patch v10-0008
v10-0009-Make-provider-data-in-pg_locale_t-an-opaque-poin.patch (text/x-patch) patch v10-0009
v10-0010-Don-t-include-ICU-headers-in-pg_locale.h.patch (text/x-patch) patch v10-0010
v10-0011-Introduce-hooks-for-creating-custom-pg_locale_t.patch (text/x-patch) patch v10-0011

On Mon, 2024-12-02 at 16:39 +0100, Andreas Karlsson wrote:
> I feel your first patch in the series is something you can just
> commit. 

Done.

I combined your patches and mine into the attached v10 series.

I also split out the ctype methods patch into two, so that patch v10-
0005 moves all of the case mapping code into the appropriate provider
files. That should make the ctype methods patch (v10-0007) easier to
review.

Regards,
	Jeff Davis

Commits

Remove provider field from pg_locale_t.
- 8af0d0ab01b4 19 (unreleased) landed
Control ctype behavior internally with a method table.
- 5a38104b3642 19 (unreleased) landed
Control collation behavior with a method table.
- a2f17f004d22 18.0 landed
Move code for collation version into provider-specific files.
- 4f5cef2607c1 18.0 landed
Refactor string case conversion into provider-specific files.
- 86a5d6006aff 18.0 landed
Move check for ucol_strcollUTF8 to pg_locale_icu.c
- 7167e05fc7d1 18.0 landed
Perform provider-specific initialization in new functions.
- 1ba0782ce90c 18.0 landed
Refactor the code to create a pg_locale_t into new function.
- 3aa2373c1141 18.0 landed