Re: pgindent exit status if a file encounters an error

On 2024-06-28 Fr 8:35 AM, Ashutosh Bapat wrote:
>
>
> On Wed, Jun 26, 2024 at 8:54 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
>     Ashutosh Bapat <ashutosh.bapat.oss@gmail.com> writes:
>     > The usage help mentions exit code 2 specifically while
>     describing --check
>     > option but it doesn't mention exit code 1. Neither does the
>     README. So I
>     > don't think we need to document exit code 3 anywhere. Please let
>     me know if
>     > you think otherwise.
>
>     I think we should have at least a code comment summarizing the
>     possible exit codes, along the lines of
>
>     # Exit codes:
>     #   0 -- all OK
>     #   1 -- could not invoke pgindent, nothing done
>     #   2 -- --check mode and at least one file requires changes
>     #   3 -- pgindent failed on at least one file
>
>
> Thanks. Here's a patch with these lines.
> In an offline chat Andrew mentioned that he expects more changes in 
> the patch and he would take care of those. Will review and test his patch.
>
>

I forget now what I was intending here, so I have committed this with 
minor tweaks.


cheers


andrew

--
Andrew Dunstan
EDB:https://www.enterprisedb.com