Re: pgindent vs. git whitespace check

Daniel Gustafsson <daniel@yesql.se>

From: Daniel Gustafsson <daniel@yesql.se>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: John Naylor <john.naylor@enterprisedb.com>, Andrew Dunstan <andrew@dunslane.net>, Peter Eisentraut <peter.eisentraut@enterprisedb.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2023-02-23T08:36:00Z
Lists: pgsql-hackers
> On 23 Feb 2023, at 05:48, Tom Lane <tgl@sss.pgh.pa.us> wrote:

> For my own taste, I really don't have any objection to // in isolation --
> the problem with it is just that we've got megabytes of code in the other
> style.  I fear it'd look really ugly to have an intermixture of // and /*
> comment styles.  

We could use the "use the style of surrounding code (comments)" approach - when
changing an existing commented function use the style already present; when
adding a net new function a choice can be made (unless we mandate a style).  It
will still look ugly, but it will be less bad than mixing within the same
block.

> Mass conversion of /* to // style would answer that,
> but would also create an impossible back-patching problem.

Yeah, that sounds incredibly invasive.

--
Daniel Gustafsson




Commits

  1. Fix comment indentation and whitespace