Horton

Thread

Commits

  1. Sort syscache identifiers into alphabetical order.

  2. Logical replication

  1. syscache entries out of order

    Mark Dilger <hornschnorter@gmail.com> — 2017-05-30T20:28:17Z

    Peter,

Just FYI, as of 665d1fad99e7b11678b0d5fa24d2898424243cd6, syscache.h
entries are not in alphabetical order, which violates the coding standard
specified in the comment for these entries.  In particular, it is the PUBLICATION
and SUBSCRIPTION entries that are mis-ordered.

Sorry for my pedantry.  Patch attached.

Mark Dilger

  2. Re: syscache entries out of order

    Tom Lane <tgl@sss.pgh.pa.us> — 2017-05-30T22:48:19Z

    Mark Dilger <hornschnorter@gmail.com> writes:
> Just FYI, as of 665d1fad99e7b11678b0d5fa24d2898424243cd6, syscache.h
> entries are not in alphabetical order, which violates the coding standard
> specified in the comment for these entries.  In particular, it is the PUBLICATION
> and SUBSCRIPTION entries that are mis-ordered.

Agreed, this is the project convention and we should follow it.

> Sorry for my pedantry.  Patch attached.

Patch pushed.

			regards, tom lane